Collect custom fields in custom beats #8397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
discuss
jsoriano
force-pushed
the
custom-beat-fields
branch
from
0a14359 to
2c4913c
Compare
jsoriano
added
needs_backport
|
I think you need to run |
|
I couldn't see any change with |
kvch
approved these changes
Sep 25, 2018
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 25, 2018
(cherry picked from commit ac6a9fb)
jsoriano
added
v6.5.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 25, 2018
(cherry picked from commit ac6a9fb)
jsoriano
added a commit
that referenced
this pull request
Sep 25, 2018
jsoriano
added a commit
that referenced
this pull request
Oct 16, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit bd43568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
_meta/fields.ymlin the list of common fields, so fields defined in custom beats are used.Current fields generator is checking for fields in
_meta/fields.common.yml, but not on_meta/fields.yml, where custom beats have their fields by default.Alternativelly we could move
generator/beat/{beat}/_meta/fields.ymltogenerator/beat/{beat}/_meta/fields.common.yml, but in any case this change could be good for existing beats that have their fields in_meta/fields.yml.There are users reporting problems with fields in custom beats that could be caused by this:
https://discuss.elastic.co/t/defining-dynamic-types-in-field-yml/149173